Skip to content
GitLab
Commit 7685d3a5 authored by Alexandre Duret-Lutz's avatar Alexandre Duret-Lutz
Browse files

* src/ltlvisit/dump.hh (dump): Take a formula* as argument, 

not a formula&.  This is more homogeneous.
* src/ltlvisit/dump.cc (dump): Likewise.
* src/ltlvisit/dotty.hh (dotty): Likewise.
* src/ltlvisit/dotty.cc (dotty): Likewise.
* src/ltlvisit/tostring.hh (to_string): Likewise.
* src/ltlvisit/tostring.cc (to_string): Likewise.
* src/ltltest/readltl.cc, src/ltltest/equals.cc,
src/ltltest/tostring.cc: Adjust usage.
parent 35f77be6
Hide whitespace changes
Inline Side-by-side
ChangeLog
View file @ 7685d3a5
2003-05-16 Alexandre Duret-Lutz <aduret@src.lip6.fr>
* src/ltlvisit/dump.hh (dump): Take a formula* as argument,
not a formula&. This is more homogeneous.
* src/ltlvisit/dump.cc (dump): Likewise.
* src/ltlvisit/dotty.hh (dotty): Likewise.
* src/ltlvisit/dotty.cc (dotty): Likewise.
* src/ltlvisit/tostring.hh (to_string): Likewise.
* src/ltlvisit/tostring.cc (to_string): Likewise.
* src/ltltest/readltl.cc, src/ltltest/equals.cc,
src/ltltest/tostring.cc: Adjust usage.
Check trivial multop equality at build time. The makes the
equal visitor useless, since two equals formulae will now
share the same address.
* src/ltlast/multop.hh (add_sorted): New function.
(paircmp): New comparison functor.
(map): Use paircmp, we want to compare the vectors' contents,
......
src/ltltest/equals.cc
View file @ 7685d3a5
......@@ -38,26 +38,23 @@ main(int argc, char** argv)
#endif
#ifdef LUNABBREV
tmp = f1;
std::cout << spot::ltl::atomic_prop::instance_count() << std::endl;
f1 = spot::ltl::unabbreviate_logic(f1);
std::cout << spot::ltl::atomic_prop::instance_count() << std::endl;
spot::ltl::destroy(tmp);
std::cout << spot::ltl::atomic_prop::instance_count() << std::endl;
spot::ltl::dump(*f1, std::cout);
spot::ltl::dump(f1, std::cout);
std::cout << std::endl;
#endif
#ifdef TUNABBREV
tmp = f1;
f1 = spot::ltl::unabbreviate_ltl(f1);
spot::ltl::destroy(tmp);
spot::ltl::dump(*f1, std::cout);
spot::ltl::dump(f1, std::cout);
std::cout << std::endl;
#endif
#ifdef NENOFORM
tmp = f1;
f1 = spot::ltl::negative_normal_form(f1);
spot::ltl::destroy(tmp);
spot::ltl::dump(*f1, std::cout);
spot::ltl::dump(f1, std::cout);
std::cout << std::endl;
#endif
......
src/ltltest/readltl.cc
View file @ 7685d3a5
......@@ -43,9 +43,9 @@ main(int argc, char** argv)
if (f)
{
#ifdef DOTTY
spot::ltl::dotty(*f, std::cout);
spot::ltl::dotty(f, std::cout);
#else
spot::ltl::dump(*f, std::cout);
spot::ltl::dump(f, std::cout);
std::cout << std::endl;
#endif
spot::ltl::destroy(f);
......
src/ltltest/tostring.cc
View file @ 7685d3a5
......@@ -26,7 +26,7 @@ main(int argc, char **argv)
// The string generated from an abstract tree should be parsable
// again.
std::string f1s = spot::ltl::to_string(*f1);
std::string f1s = spot::ltl::to_string(f1);
std::cout << f1s << std::endl;
spot::ltl::formula* f2 = spot::ltl::parse(f1s, p1);
......@@ -41,7 +41,7 @@ main(int argc, char **argv)
// It should also map to the same string.
std::string f2s = spot::ltl::to_string(*f2);
std::string f2s = spot::ltl::to_string(f2);
std::cout << f2s << std::endl;
if (f2s != f1s)
......
src/ltlvisit/dotty.cc
View file @ 7685d3a5
......@@ -3,7 +3,7 @@
#include "ltlast/allnodes.hh"
namespace spot
namespace spot
{
namespace ltl
{
......@@ -16,12 +16,12 @@ namespace spot
{
}
virtual
virtual
~dotty_visitor()
{
}
void
void
visit(const spot::ltl::atomic_prop* ap)
{
draw_node_(ap->name());
......@@ -32,20 +32,20 @@ namespace spot
{
draw_node_(c->val_name());
}
void
visit(const spot::ltl::binop* bo)
{
draw_rec_node_(bo->op_name());
std::string label = label_;
label_ += "l";
draw_link_(label, label_);
bo->first()->accept(*this);
label_ = draw_link_(label, label + "r");
bo->second()->accept(*this);
}
void
visit(const spot::ltl::unop* uo)
{
......@@ -53,7 +53,7 @@ namespace spot
label_ = draw_link_(label_, label_ + "c");
uo->child()->accept(*this);
}
void
visit(const spot::ltl::multop* mo)
{
......@@ -79,10 +79,10 @@ namespace spot
return out;
}
void
void
draw_rec_node_(const char* str) const
{
os_ << " " << label_ << " [label=\"" << str << "\", shabe=box];"
os_ << " " << label_ << " [label=\"" << str << "\", shabe=box];"
<< std::endl;
}
......@@ -91,15 +91,15 @@ namespace spot
{
os_ << " " << label_ << " [label=\"" << str << "\"];" << std::endl;
}
};
void
dotty(const formula& f, std::ostream& os)
void
dotty(const formula* f, std::ostream& os)
{
dotty_visitor v(os);
os << "digraph G {" << std::endl;
f.accept(v);
f->accept(v);
os << "}" << std::endl;
}
......
src/ltlvisit/dotty.hh
View file @ 7685d3a5
......@@ -4,7 +4,7 @@
#include <ltlast/formula.hh>
#include <iostream>
namespace spot
namespace spot
{
namespace ltl
{
......@@ -14,7 +14,7 @@ namespace spot
///
/// \c dot is part of the GraphViz package
/// http://www.research.att.com/sw/tools/graphviz/
void dotty(const formula& f, std::ostream& os);
void dotty(const formula* f, std::ostream& os);
}
}
......
src/ltlvisit/dump.cc
View file @ 7685d3a5
......@@ -3,7 +3,7 @@
#include "ltlast/allnodes.hh"
namespace spot
namespace spot
{
namespace ltl
{
......@@ -15,13 +15,13 @@ namespace spot
: os_(os)
{
}
virtual
virtual
~dump_visitor()
{
}
void
void
visit(const spot::ltl::atomic_prop* ap)
{
os_ << "AP(" << ap->name() << ")";
......@@ -31,8 +31,8 @@ namespace spot
visit(const spot::ltl::constant* c)
{
os_ << "constant(" << c->val_name() << ")";
}
}
void
visit(const spot::ltl::binop* bo)
{
......@@ -42,7 +42,7 @@ namespace spot
bo->second()->accept(*this);
os_ << ")";
}
void
visit(const spot::ltl::unop* uo)
{
......@@ -50,7 +50,7 @@ namespace spot
uo->child()->accept(*this);
os_ << ")";
}
void
visit(const spot::ltl::multop* mo)
{
......@@ -68,11 +68,11 @@ namespace spot
std::ostream& os_;
};
void
dump(const formula& f, std::ostream& os)
void
dump(const formula* f, std::ostream& os)
{
dump_visitor v(os);
f.accept(v);
f->accept(v);
}
}
......
src/ltlvisit/dump.hh
View file @ 7685d3a5
......@@ -4,7 +4,7 @@
#include "ltlast/formula.hh"
#include <iostream>
namespace spot
namespace spot
{
namespace ltl
{
......@@ -13,7 +13,7 @@ namespace spot
/// \param os The stream where it should be output.
///
/// This is useful to display a formula when debugging.
void dump(const formula& f, std::ostream& os);
void dump(const formula* f, std::ostream& os);
}
}
......
src/ltlvisit/tostring.cc
View file @ 7685d3a5
......@@ -5,7 +5,7 @@
#include "ltlast/allnodes.hh"
namespace spot
namespace spot
{
namespace ltl
{
......@@ -17,13 +17,13 @@ namespace spot
: os_(os)
{
}
virtual
virtual
~to_string_visitor()
{
}
void
void
visit(const atomic_prop* ap)
{
os_ << ap->name();
......@@ -33,14 +33,14 @@ namespace spot
visit(const constant* c)
{
os_ << c->val_name();
}
}
void
visit(const binop* bo)
{
os_ << "(";
bo->first()->accept(*this);
switch(bo->op())
{
case binop::Xor:
......@@ -59,14 +59,14 @@ namespace spot
os_ << " R ";
break;
}
bo->second()->accept(*this);
os_ << ")";
}
void
visit(const unop* uo)
{
{
switch(uo->op())
{
case unop::Not:
......@@ -82,10 +82,10 @@ namespace spot
os_ << "G";
break;
}
uo->child()->accept(*this);
}
void
visit(const multop* mo)
{
......@@ -97,12 +97,12 @@ namespace spot
{
case multop::Or:
ch = " | ";
break;
break;
case multop::And:
ch = " & ";
break;
}
for (unsigned n = 1; n < max; ++n)
{
os_ << ch;
......@@ -113,16 +113,16 @@ namespace spot
private:
std::ostream& os_;
};
void
to_string(const formula& f, std::ostream& os)
void
to_string(const formula* f, std::ostream& os)
{
to_string_visitor v(os);
f.accept(v);
f->accept(v);
}
std::string
to_string(const formula& f)
std::string
to_string(const formula* f)
{
std::ostringstream os;
to_string(f, os);
......
src/ltlvisit/tostring.hh
View file @ 7685d3a5
......@@ -4,12 +4,12 @@
#include <ltlast/formula.hh>
#include <iostream>
namespace spot
namespace spot
{
namespace ltl
{
void to_string(const formula& f, std::ostream& os);
std::string to_string(const formula& f);
void to_string(const formula* f, std::ostream& os);
std::string to_string(const formula* f);
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment