Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Spot Spot
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 134
    • Issues 134
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SpotSpot
  • SpotSpot
  • Issues
  • #235
Closed
Open
Issue created Feb 27, 2017 by Alexandre Duret-Lutz@adlOwner

spot.ltsmin.require('divine') should check the exit status

Currently it does

            if shutil.which("divine") == None:
                print("divine not available", file=sys.stderr)
                sys.exit(77)
            out = subprocess.check_output(['divine', 'compile', '--help'],
                                          stderr=subprocess.STDOUT)
            if b'LTSmin' not in out:
                print("divine available but no support for LTSmin",
                       file=sys.stderr)
                sys.exit(77)

However if divine compile --help terminates with a non-zero exit code (as in the current version of divine), this triggers an exception and that causes our tests to fail instead of being skipped.

Reported by @xlauko.

Assignee
Assign to
Time tracking